test(titlebar): fix TitleBar.syncState flake from cold-transform timeout - #147
Merged
Conversation
The first test imported ./TitleBar dynamically, so vitest cold-transformed the component's whole dependency graph inside that test's 5s timeout. Under load the transform alone exceeded it and the first test failed while the second passed on the warm cache. Import once in beforeAll, which carries its own timeout and is not billed to any single test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The first test in
TitleBar.syncState.test.tsxdidawait import("./TitleBar")inside the test body. That cold-transforms TitleBar's entire dependency graph within the test's default 5s timeout. Under load the transform alone exceeds 5s, so the first test times out while the second passes on the now-warm module cache.Confirmed pre-existing on a pristine
origin/devcheckout — not a regression, but it produces false failures in full-suite CI gates.Fix
Hoist the import into
beforeAll(given its own 20s timeout), so the cold transform is paid once outside any single test's timeout window. Both tests become synchronous and reuse the hoisted binding.Test-only change, one file. No source files touched.